Skip to content

Changed border default for theme_grey() #3414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2019
Merged

Changed border default for theme_grey() #3414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5fb7e2c
Added weight aesthetic option to stat_density() and made scaling of w…
annennenne Jul 8, 2019
602c613
Changed theme_grey() setting for legend key so that it creates no bor…
annennenne Jul 8, 2019
663445a
Changed theme_grey() setting for legend key so that it creates no bor…
annennenne Jul 8, 2019
3211222
Merge branch 'devday_3180' of https://github.com/annennenne/ggplot2 i…
annennenne Jul 8, 2019
49e8ec4
Merge branch 'master' into devday_3180
annennenne Jul 8, 2019
0fb7708
Reinserted bullet from news that I accidentially deleted.
annennenne Jul 8, 2019
8858a65
update visual test cases for theme_gray() updates
paleolimbot Jul 8, 2019
7dc2929
Merge branch 'master' into devday_3180
paleolimbot Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# ggplot2 (development version)

* Changed `theme_grey()` setting for legend key so that it creates no
border (`NA`) rather than drawing a white one. (@annennenne, #3180)

* Added function `ggplot_add.by()` for lists created with `by()` (#2734, @Maschette)

* `ggdep()` was deprecated (@perezp44, #3382).
Expand Down
2 changes: 1 addition & 1 deletion R/theme-defaults.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ theme_grey <- function(base_size = 11, base_family = "",
legend.spacing.x = NULL,
legend.spacing.y = NULL,
legend.margin = margin(half_line, half_line, half_line, half_line),
legend.key = element_rect(fill = "grey95", colour = "white"),
legend.key = element_rect(fill = "grey95", colour = NA),
legend.key.size = unit(1.2, "lines"),
legend.key.height = NULL,
legend.key.width = NULL,
Expand Down
4 changes: 2 additions & 2 deletions tests/figs/themes/theme-gray-large.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/figs/themes/theme-gray.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.