Skip to content

Issue 2767 #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2019
Merged

Issue 2767 #3418

merged 3 commits into from
Jul 17, 2019

Conversation

CateGitau
Copy link
Contributor

issue #2767

Added some information about position_dodge2()

@hadley
Copy link
Member

hadley commented Jul 8, 2019

It looks like your changes got tangled up with your other PR - this is typically because you're not creating a branch for each PR. Undoing is a little tricky so you might want to find a helper.

@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 8, 2019
@CateGitau
Copy link
Contributor Author

Fixed this.

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I ran devtools::document() to sync your changes with the .Rd files. Could you add a NEWS bullet (after Pulling my changes in the RStudio "Git" tab)?

@hadley
Copy link
Member

hadley commented Jul 16, 2019

Generally, I don't think we bother with NEWS bullets for documentation fixes (unless they're v. large)

@paleolimbot paleolimbot merged commit 0cdde1d into tidyverse:master Jul 17, 2019
@paleolimbot
Copy link
Member

I stand corrected! Thanks @CateGitau!

@lock
Copy link

lock bot commented Jan 13, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants