Skip to content

Explicit warning about data removal with limits on positional scales #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 8, 2019
Merged

Explicit warning about data removal with limits on positional scales #3421

merged 3 commits into from
Jul 8, 2019

Conversation

jfalip
Copy link
Contributor

@jfalip jfalip commented Jul 8, 2019

Fixes #2887

Added an explicit warning in scales documentation about limits sometimes removing data.

@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 8, 2019
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good — I added a couple of extra ideas to make it even better.

@hadley hadley merged commit a8f94c1 into tidyverse:master Jul 8, 2019
@hadley
Copy link
Member

hadley commented Jul 8, 2019

Thanks @elesday!

@lock
Copy link

lock bot commented Jan 4, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should limits be enforced on the calculated geoms?
3 participants