Skip to content

Improving documentation for geom_histogram(). #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2019

Conversation

accustodio
Copy link
Contributor

  • Details about modifing binwidths and center/boundary
  • Removed repeated word from stat-bin documentation

Closes #3269

- Details about modifing binwidths and center/boundary
- Removed repeated word from stat-bin documentation
@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 8, 2019
#' The default is to use `bins`
#' bins that cover the range of the data. You should always override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might have been intentional, i.e. "The default is to use bins [i.e. the bins parameter] number of bins". Maybe another way to word this would be "The default is to use the number of bins in bins, covering the range of the data"?

Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Angelica93 (and @karawoo for the review!)

@paleolimbot paleolimbot merged commit 7b09de3 into tidyverse:master Jul 16, 2019
@lock
Copy link

lock bot commented Jan 12, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved documentation for geom_histogram()
4 participants