Skip to content

Add regression tests for geom_quantile()/stat_quantile() #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

EK-Lee
Copy link

@EK-Lee EK-Lee commented Jul 8, 2019

fixes #3135 : add test-geom-quantile.R

@batpigandme batpigandme added the tidy-dev-day 🤓 Tidyverse Developer Day label Jul 8, 2019
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! Testing the layer_data() of a basic quantile regression plot is exactly what we had in mind. Unfortunately, you will have to update the testing format you've used in order for the checks to pass in ggplot2. In our tests, we don't library() any packages (because our users might not have library()ed them either). If you could:

  • Remove the library() calls
  • Replace tibble() with data_frame() (to get this to work on your computer, you'll have to run devtools::load_all(.))
  • Substitute the pipe and dplyr calls for base R data frame subsetting

We look forward to your changes!

@clauswilke
Copy link
Member

Superseded by #3774.

@clauswilke clauswilke closed this Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-dev-day 🤓 Tidyverse Developer Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add regression tests for geom_quantile()/stat_quantile()
4 participants