Force eval_facets() to return a data.frame, not a tibble #3499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3489 (I think it should be fixed on tibble's side, though)
As we saw #3048, using tibble internally causes unexpected errors because the existing codes expects a bare data.frame. I think #3489 is just a bug on tibble's side, but, I believe it's better for ggplot2 internals to stick with a bare data.frame for consistency.
Note that this pull request leaves these two
tibble()
uses as is because they don't seem the cases when the result is used internally.ggplot2/R/summarise-plot.R
Lines 66 to 70 in b842024
ggplot2/R/summarise-plot.R
Lines 134 to 136 in b842024