Skip to content

Force eval_facets() to return a data.frame, not a tibble #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Aug 23, 2019

Closes #3489 (I think it should be fixed on tibble's side, though)

As we saw #3048, using tibble internally causes unexpected errors because the existing codes expects a bare data.frame. I think #3489 is just a bug on tibble's side, but, I believe it's better for ggplot2 internals to stick with a bare data.frame for consistency.

Note that this pull request leaves these two tibble() uses as is because they don't seem the cases when the result is used internally.

layout <- tibble(
panel = l$layout$PANEL,
row = l$layout$ROW,
col = l$layout$COL
)

ggplot2/R/summarise-plot.R

Lines 134 to 136 in b842024

tibble(
mapping = layer_mappings
)

@yutannihilation yutannihilation merged commit b36c4f4 into tidyverse:master Aug 26, 2019
@yutannihilation yutannihilation deleted the fix/issue-3489-stick-with-data-frame branch August 26, 2019 11:17
@lock
Copy link

lock bot commented Feb 22, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

facet_grid() errors with the dev version of tibble
2 participants