Skip to content

move isoband from Suggests to Imports #3598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

paleolimbot
Copy link
Member

This is a pull request to fix downstream package failures when a dependency package uses stat/geom_contour(), which after #3439 uses the isoband package. As discussed in #3564, the best solution is probably to add "isoband" to Imports rather than Suggests. This PR implements this change (closes #3564).

Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paleolimbot paleolimbot merged commit 6efb0d3 into tidyverse:master Oct 30, 2019
@paleolimbot paleolimbot deleted the issue-3564-isoband-suggests branch October 30, 2019 13:51
@lock
Copy link

lock bot commented May 5, 2020

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downstream packages that use stat_contour() need to add isoband to Suggests
2 participants