Skip to content

Make sure flip is never NA #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2019
Merged

Make sure flip is never NA #3665

merged 1 commit into from
Dec 13, 2019

Conversation

thomasp85
Copy link
Member

revdepchecks uncovered a small issue in direction flipping for position subclasses that hasn't adapted to the new setup. This PR fixes it

@thomasp85 thomasp85 added this to the ggplot2 3.3.0 milestone Dec 12, 2019
@thomasp85 thomasp85 requested a review from clauswilke December 12, 2019 10:09
clauswilke
clauswilke approved these changes Dec 12, 2019
View reviewed changes
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's generally a good practice to use isTRUE(), all(), or any() in logical comparisons.

@thomasp85 thomasp85 merged commit b122e2a into tidyverse:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasp85 @clauswilke