Better handle position aesthetics in params #3666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
reviewed
Dec 12, 2019
| @@ -99,7 +99,7 @@ GeomLinerange <- ggproto("GeomLinerange", Geom, | |||
|
|
|||
| setup_params = function(data, params) { | |||
| params$flipped_aes <- has_flipped_aes(data, params, range_is_orthogonal = TRUE) | |||
| if (!(params$flipped_aes || all(c("x", "ymin", "ymax") %in% names(data)))) { | |||
| if (!(params$flipped_aes || all(c("x", "ymin", "ymax") %in% c(names(data), names(params))))) { | |||
There was a problem hiding this comment.
Just wondering why it tests for x, ymin, ymax but not y, xmin, xmax in params. Is this correct?
There was a problem hiding this comment.
if has_flipped_aes() returns true it means that it contains y, xmin, and xmax
There was a problem hiding this comment.
Ah, Ok, maybe add a quick comment.
clauswilke
reviewed
Dec 12, 2019
R/geom-linerange.r
Outdated
| @@ -113,6 +113,7 @@ GeomLinerange <- ggproto("GeomLinerange", Geom, | |||
| }, | |||
|
|
|||
| draw_panel = function(data, panel_params, coord, flipped_aes = FALSE) { | |||
| browser() | |||
There was a problem hiding this comment.
This looks left over. That's probably why the CI fails.
clauswilke
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revdepchecks uncovered an edge case in direction detection if position aesthetics are given outside aes(). This PR correctly looks in both data and params when figuring out direction