Skip to content

Fix missing backticks and newlines in NEWS.md #3742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2020
Merged

Fix missing backticks and newlines in NEWS.md #3742

merged 1 commit into from
Feb 9, 2020

Conversation

mattsteadman
Copy link
Contributor

Two missing backticks and a several missing newlines were causing incorrect or inconsistent rendering of markdown.

@yutannihilation
Copy link
Member

a several missing newlines were causing incorrect or inconsistent rendering of markdown.

I don't understand this part. Do you mean rendering on GitHub? What inconsistency do your newlines fix...?

@mattsteadman
Copy link
Contributor Author

a several missing newlines were causing incorrect or inconsistent rendering of markdown.

I don't understand this part. Do you mean rendering on GitHub? What inconsistency do your newlines fix...?

When viewed in a text editor with word wrap off, every line but the ones I changed are manually wrapped at ~80 chars, and stuck out significantly. The missing backticks were causing text that was intented to be monospaced to not be.

@yutannihilation
Copy link
Member

When viewed in a text editor with word wrap off, every line but the ones I changed are manually wrapped at ~80 chars, and stuck out significantly.

Thanks. Personally, I don't feel this is a problem, but this seems harmless to merge.

The missing backticks are definetely what needs to be fixed. Thanks for catching this!

@yutannihilation yutannihilation merged commit 0137a4d into tidyverse:master Feb 9, 2020
sthagen added a commit to sthagen/tidyverse-ggplot2 that referenced this pull request Feb 10, 2020
Fix missing backticks and newlines in NEWS.md (tidyverse#3742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants