Do not flip eagerly when both axis are discrete like #3763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasp85 PTAL after rstudio::conf. Sorry for bothering you.... |
thomasp85
approved these changes
Feb 3, 2020
|
Thanks. Yeah, datetime scales tend to slip our mind... It cannot be perfect to guess how "descrete-ish" the scale is only from the internal representation, so I vaguely feel we might face more tricky cases where we want the scale information. But, let's consider it when we actually see some issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3761
Currently, we try to make a precise guess in
has_flipped_aes(), but it seems the guess goes wrong in some cases when both axis are discrete like. I don't know what the proper fix would be, but I think it's rather safe to stay unflipped when we are not fully sure it's flippable, considering we want to avoid introducing some big change to the current RC branch.