update theme documentation reference links & clarify differences between theme_set and theme_update() #3782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…between theme_set() and theme_update() with examples, references #3294
clauswilke
reviewed
Jan 31, 2020
R/theme-current.R
Outdated
| #' theme element will default to the values they are set in the theme. | ||
| #' `theme_replace` uses `%+replace%` to completely replace the element, so any | ||
| #' unspecified values will overwrite the current value in the theme with | ||
| #' `NULL`s. |
There was a problem hiding this comment.
This should be singular, "NULL" not "NULLs".
clauswilke
reviewed
Jan 31, 2020
R/theme-current.R
Outdated
| #' | ||
| #' # `theme_set()` completely overrides the current theme. | ||
| #' # `theme_update()` modifies a particular element of the current theme. | ||
| #' theme_set(theme_classic()) |
There was a problem hiding this comment.
A similar example is already given further up in the examples. Please move this entire block up and merge with the previous example of theme_set(). Also, it's important to undo any changes to the default theme at the end of the example.
clauswilke
reviewed
Jan 31, 2020
R/theme-current.R
Outdated
| #' | ||
| #' The main difference between `theme_set()` and `theme_update()` is: | ||
| #' * `theme_set()` completely overrides the current theme. | ||
| #' * `theme_update()` modifies a particular element of the current theme. |
There was a problem hiding this comment.
Shouldn't theme_replace() also be listed in this bullet point list?
clauswilke
reviewed
Jan 31, 2020
R/theme-current.R
Outdated
| #' p | ||
| #' | ||
| #' theme_update(panel.grid.major.y = element_line(colour = "gray")) | ||
| #' p |
There was a problem hiding this comment.
This example needs to be moved up also, together with the previous one.
…ary, merge all update/set/replace examples into one section, references #3294
… comparison, references #3294
|
Sorry, the example still doesn't quite show what I mean. Try the following instead: # minor tick lines remain thin
theme_update(panel.grid.minor = element_line(colour = "red"))
...
# minor tick lines turn thick
theme_replace(panel.grid.minor = element_line(colour = "red"))
... |
clauswilke
approved these changes
Feb 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3294