Skip to content

fix unit test. #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

fix unit test. #3792

merged 1 commit into from
Feb 1, 2020

Conversation

clauswilke
Copy link
Member

closes #3791

yutannihilation
yutannihilation approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we need this for the RC branch as well?

@clauswilke
Copy link
Member Author

No, this problem was introduced to master today.

@clauswilke clauswilke merged commit b8ce6a9 into tidyverse:master Feb 1, 2020
@clauswilke clauswilke deleted the issue-3791-unit-test branch February 1, 2020 07:46
@yutannihilation
Copy link
Member

I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutannihilation yutannihilation yutannihilation approved these changes

@thomasp85 thomasp85 Awaiting requested review from thomasp85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests failing
2 participants
@clauswilke @yutannihilation