Add support for native rasters to annotation_raster() #3388
#3794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you merge in the master branch so the unit tests don't fail? |
|
@clauswilke I'm not sure I understand what you want me to merge. My branch is based on the tip of the master branch; do you want me to merge it into master myself? |
|
Ah, sorry, we had a bunch of PRs last week that were based off of a version of master that was failing unit tests, but that's not your case. Looks like your checks are passing, except one random issue on travis. |
|
Yes, the Travis issue doesn't seem to be related to my change, it is failing to install R 3.2. Let me know if there is anything else you want me to do. |
|
No, I think it's fine, thanks! |
clauswilke
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to allow passing a
nativeRasterobject toannotation_raster(). This is a significant performance improvement for large rasters.I didn't include an example because I don't see a source for a native raster in
{ggplot2}. I could use the R logo from{png}but that package is not currently used by ggplot2. If you think an example is called for, please advise.