Skip to content

Fix seq partial argument names #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix seq partial argument names #3817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions icons/icons.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ write_icon("geom_bar", {

write_icon("geom_bin2d", {
n <- 5
x <- seq(0, 1, length = n + 1)[-(n + 1)]
x <- seq(0, 1, length.out = n + 1)[-(n + 1)]
out <- expand.grid(x = x, y = x)
fill <- sqrt((out$x - 0.5) ^ 2 + (out$y - 0.5) ^ 2)

Expand Down Expand Up @@ -239,7 +239,7 @@ write_icon("geom_contour", {
})

write_icon("geom_hex", {
theta <- seq(0, 2 * pi, length = 7)[-1]
theta <- seq(0, 2 * pi, length.out = 7)[-1]
polygonGrob(
0.5 + 0.4 * sin(theta),
0.5 + 0.4 * cos(theta),
Expand Down Expand Up @@ -343,8 +343,8 @@ write_icon("geom_ribbon", {
})

write_icon("geom_spoke", {
theta <- seq(0, 2 * pi, length = 10)[-1]
r <- seq(0.1, 0.45, length = length(theta))
theta <- seq(0, 2 * pi, length.out = 10)[-1]
r <- seq(0.1, 0.45, length.out = length(theta))
segmentsGrob(
0.5, 0.5,
0.5 + sin(theta) * r,
Expand All @@ -367,7 +367,7 @@ write_icon("geom_density", {


write_icon("geom_rug", {
x <- seq(0.15, 0.95, length = 8)
x <- seq(0.15, 0.95, length.out = 8)
gList(
segmentsGrob(x, 0, x, 0 + 0.1, gp = gpar(lwd = 2)),
segmentsGrob(0, x, 0 + 0.1, x, gp = gpar(lwd = 2))
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-aes-setting.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test_that("aesthetic parameters match length of data", {
test_that("legend filters out aesthetics not of length 1", {
df <- data_frame(x = 1:5, y = 1:5)
p <- ggplot(df, aes(x, y, colour = factor(x))) +
geom_point(alpha = seq(0, 1, length = 5))
geom_point(alpha = seq(0, 1, length.out = 5))

# Ideally would test something in the legend data structure, but
# that's not easily accessible currently.
Expand Down
4 changes: 2 additions & 2 deletions tests/testthat/test-geom-quantile.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ test_that("geom_quantile matches quantile regression", {
data = df
),
tibble::tibble(
x = seq(min(x), max(x), length = 100)
x = seq(min(x), max(x), length.out = 100)
)
)

pred_rq <- cbind(seq(min(x), max(x), length = 100), pred_rq)
pred_rq <- cbind(seq(min(x), max(x), length.out = 100), pred_rq)
colnames(pred_rq) <- c("x", paste("Q", quants * 100, sep = "_"))

ggplot_data <- tibble::as_tibble(layer_data(ps))
Expand Down