Use rlang to generate quosure list #3842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids making assumptions about internals of quosure lists
|
Does this just fix broken unit tests, or does it affect the user experience? |
|
This just fixes a broken test that made assumptions about the internals of quosure lists. They now explictly inherit from "list". |
hadley
approved these changes
Feb 28, 2020
sthagen
added a commit
to sthagen/tidyverse-ggplot2
that referenced
this pull request
Feb 28, 2020
Use rlang to generate quosure list (tidyverse#3842)
|
Maybe this should be included in version 3.3? |
|
Yes this should be merged into rc as well |
|
Can one of you do it please? I'm not familiar with the rc branch. |
|
Sure. |
yutannihilation
pushed a commit
to yutannihilation/ggplot2
that referenced
this pull request
Feb 29, 2020
Avoids making assumptions about internals of quosure lists
yutannihilation
added a commit
that referenced
this pull request
Feb 29, 2020
Avoids making assumptions about internals of quosure lists Co-authored-by: Lionel Henry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids making assumptions about internals of quosure lists. Fixes a test failure with dev rlang.