Skip to content

ignore min/max variables when detecting orientation in geom_bar #3882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasp85
Copy link
Member

Fixes #3866

The check for range_is_orthogonal in geom_bar() was unneeded and resulted in failure with edge cases

@thomasp85 thomasp85 added this to the ggplot2 3.3.1 milestone Mar 10, 2020
Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you fix the document as well?

ggplot2/R/utilities.r

Lines 456 to 461 in bb86d33

#' - `range_is_orthogonal`: This argument controls whether the existance of
#' range-like aesthetics (e.g. `xmin` and `xmax`) represents the main or
#' secondary axis. If `TRUE` then the range is given for the secondary axis as
#' seen in e.g. [geom_ribbon()] and [geom_linerange()]. `FALSE` is less
#' prevalent but can be seen in [geom_bar()] where it may encode the span of
#' each bar.

@yutannihilation
Copy link
Member

could you fix the document

I mean I just want you to remove this sentence since geom_bar() no longer uses this option after this PR gets merged.

 #'   ... `FALSE` is less 
 #'   prevalent but can be seen in [geom_bar()] where it may encode the span of 
 #'   each bar. 

@yutannihilation
Copy link
Member

@thomasp85 May I tweak the document and merge this?

@thomasp85
Copy link
Member Author

Yes — sure. I’ve been elsewhere for a while

@yutannihilation
Copy link
Member

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

geom_bar() is broken!
2 participants