Skip to content

Import lifecycle #3902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Import lifecycle #3902

merged 2 commits into from
Mar 20, 2020

Conversation

romainfrancois
Copy link
Member

This seems to address #3900

I don't really understand why though 🤷‍♂

@thomasp85
Copy link
Member

I really don't like doing this without understanding the root cause... we have been working a lot on cutting dependencies so this runs a bit counter to it...

@clauswilke
Copy link
Member

At some point we re-exported some dplyr functions for some reason. I don't remember the details, but it was necessary at the time. Do we still do that? If yes I bet that's the root cause.

@clauswilke
Copy link
Member

ggplot2/R/zzz.r

Lines 54 to 59 in 3ddfc3f

# To avoid namespace clash with dplyr.
# It seems surprising that this hack works
if (requireNamespace("dplyr", quietly = TRUE)) {
vars <<- dplyr::vars
}
}

@romainfrancois
Copy link
Member Author

Updated based on conversation in #3900

@clauswilke clauswilke merged commit f8bcc75 into tidyverse:master Mar 20, 2020
@clauswilke clauswilke mentioned this pull request Mar 20, 2020
sthagen added a commit to sthagen/tidyverse-ggplot2 that referenced this pull request Mar 20, 2020
clauswilke added a commit that referenced this pull request Mar 21, 2020
clauswilke added a commit that referenced this pull request Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants