Skip to content

Fix CI failures #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2020
Merged

Fix CI failures #4046

merged 5 commits into from
Jun 9, 2020

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Jun 6, 2020 •
edited
Loading

Fix #4045

We need two fixes here:

  • For the macOS (devel) runner, bump cache version to clear the cache
  • For the Linux (<3.6) runner, install the dev version of rmarkdown package. This will be unnecessary after the next version of rmarkdown is released on CRAN.

@yutannihilation yutannihilation mentioned this pull request Jun 6, 2020
Closed
@yutannihilation yutannihilation changed the title Bump cache version Fix CI failures Jun 6, 2020
@yutannihilation
Copy link
Member Author

Hmm, is something wrong with R 4.0.1 installer?

@yutannihilation
Copy link
Member Author

Ah, it seems this is the cause. Let's wait for a while.

r-lib/actions#116 (comment)

karawoo
karawoo approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are we planning to keep travis and appveyor now that we're using github actions too?

@karawoo karawoo mentioned this pull request Jun 8, 2020
Merged
@yutannihilation
Copy link
Member Author

Thanks!

Are we planning to keep travis and appveyor now that we're using github actions too?

At the time of enabling GitHub Actions CI (#3862 (comment)), the things were very unstable so I felt it was better to keep Travis and AppVayor until we're sure GitHub Actions CI is reliable enough. But, it might be time to remove them now. I'll create another PR for this. Thanks for catching.

@yutannihilation yutannihilation merged commit 01df437 into tidyverse:master Jun 9, 2020
@yutannihilation yutannihilation deleted the ci/bump-cache-version branch June 9, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karawoo karawoo karawoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI tests failing
2 participants
@yutannihilation @karawoo