Skip to content

Remove a workaround about rmarkdown on R <3.6 #4069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

yutannihilation
Copy link
Member

The new version of rmarkdown was released on CRAN and it now contains the fix for tools::vignetteInfo() errors. The workaround is no longer needed.

Copy link
Member

@karawoo karawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I guess we don't need to bump the cache version because it's already passing with the dev version?

@yutannihilation
Copy link
Member Author

Thanks. Yeah, I don't think the version of the rmarkdown matters much at the moment as there are few differences between the CRAN version and the GitHub one. Let's leave the version as it is this time.

@yutannihilation yutannihilation merged commit 98e7eb3 into tidyverse:master Jun 20, 2020
@yutannihilation yutannihilation deleted the ci/revert-using-dev-rmarkdown branch June 20, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants