Skip to content

Update utilities-tidy-eval.R and use as_label() #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Jun 20, 2020

Close #4063

What I did to create this PR was:

  • update utils-tidy-eval.R by usethis::use_tidy_eval()
  • add @export quo_name for backward-compatibility, considering we've been exporting it for 2 years with a documentation using it
  • replace quo_name() with as_label() in the code and the docs

As a result, this PR changes the following two points:

  • adds some new re-exported functions :=, as_name(), and as_label().
  • removes some re-exported functions quo(), quos(), enexpr(), enexprs(), ensym(), ensyms(); they are different than quo_name() in that no documentations of ggplot2 refer to them, so I believe it's OK to remove them.

@yutannihilation yutannihilation requested a review from lionel- June 21, 2020 02:29
@yutannihilation
Copy link
Member Author

@lionel-
Sorry to bother you. Could you take a look when you have time? I believe this PR is safe to merge, but I want to confirm if this is consistent with the latest direction of rlang things.

Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have opened an issue about updating the template because it should now recommend reading the dplyr and ggplot2 programming vignettes: r-lib/rlang#1008

Regarding backward compatibility, it might still cause issues to remove the other operators from the package because they were mentioned in the old dplyr programming vignette or in the tidyeval bookdown. To be safe it would be better to keep them in an @keyword internal topic.

@yutannihilation
Copy link
Member Author

Thanks! OK, let's keep other functions as well.

@yutannihilation yutannihilation merged commit 73256c9 into tidyverse:master Jun 21, 2020
@yutannihilation yutannihilation deleted the fix/issue-4063-use-as_label branch June 21, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use as_label() instead of quo_name()
2 participants