Skip to content

Ignore Rd xref warnings on R 3.2 #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

Ignore Rd xref warnings on R 3.2 #4096

merged 3 commits into from
Jun 26, 2020

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Jun 26, 2020 •
edited
Loading

Close #4095

According to R-internals, we can avoid the warning by setting _R_CHECK_RD_XREFS_ to FALSE.

@yutannihilation yutannihilation changed the title Set _R_CHECK_RD_XREFS_ Ignore Rd xref warnings on R 3.2 Jun 26, 2020
@yutannihilation
Copy link
Member Author

Hmm, seems we cannot leave _R_CHECK_RD_XREFS_ as empty...

* checking Rd metadata ... OK
Error in if (dir.exists("man") && R_check_Rd_xrefs) { : 
  missing value where TRUE/FALSE needed
Execution halted

clauswilke
clauswilke approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Btw., why are there still appveyor runs if they always fail? Should they be disabled?

@yutannihilation
Copy link
Member Author

Thanks.

Should they be disabled?

Yes. I asked Thomas and Hadley to disable it (assuming they have admin privilege of this repo) on #4053 (comment), but it seems my voice doesn't reach them yet...

@yutannihilation yutannihilation merged commit cb0cfd2 into master Jun 26, 2020
@yutannihilation yutannihilation deleted the ci/issue-4095-ignore-xref-warning-on-R3.2 branch June 26, 2020 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failure on R 3.2
2 participants
@yutannihilation @clauswilke