Skip to content

Very experimental use of vctrs #4342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Very experimental use of vctrs #4342

wants to merge 1 commit into from

Conversation

hadley
Copy link
Member

@hadley hadley commented Feb 6, 2021

Just a 15 minute experiment. I have no recollection of how the facet data structure works, so this is just banging rocks together.

Fixes #4175

@hadley hadley mentioned this pull request Feb 6, 2021
Closed
@hadley
Copy link
Member Author

hadley commented Feb 7, 2021

  • When implementing this for real, may want to do it in such away that the non-vctrs code lives on so we can give the users the ability to switch back to the old version if desired
  • Need to fundamentally rethink how facet data matching works using vctrs primiitves

@thomasp85 thomasp85 mentioned this pull request May 20, 2022
Closed
@thomasp85 thomasp85 added this to the ggplot2 3.4.0 milestone May 20, 2022
@thomasp85 thomasp85 mentioned this pull request Jun 10, 2022
Merged
@thomasp85
Copy link
Member

Closing in favour of #4868

@thomasp85 thomasp85 closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.4.0
Development

Successfully merging this pull request may close these issues.

ggplot breaks when facet variable is POSIXct with tz attribute specified
2 participants
@hadley @thomasp85