Skip to content

Show a function name instead of function call on ggsave's doc #4371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

Show a function name instead of function call on ggsave's doc #4371

merged 1 commit into from
Mar 25, 2021

Conversation

yutannihilation
Copy link
Member

Currently the document says

Can either be a device function (e.g. png()), or ...

but we cannot specify png(), but png. This seems slightly misleading.

c.f. #4347 (comment)

@thomasp85 thomasp85 added this to the ggplot2 3.3.4 milestone Mar 25, 2021
@yutannihilation yutannihilation merged commit bf8786d into tidyverse:master Mar 25, 2021
@yutannihilation yutannihilation deleted the doc/ggsave-device-function branch March 25, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@yutannihilation @thomasp85