Skip to content

Revert "Add missing US spellings for “scale_grey” (#4299)" #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2021
Merged

Revert "Add missing US spellings for “scale_grey” (#4299)" #4411

merged 1 commit into from
Apr 13, 2021

Conversation

thomasp85
Copy link
Member

This reverts commit a835207.

As discussed, adding the additional spelling is more trouble than it is worth so this PR reverts it

@thomasp85 thomasp85 added this to the ggplot2 3.3.4 milestone Apr 12, 2021
@thomasp85 thomasp85 requested a review from clauswilke April 12, 2021 10:38
clauswilke
clauswilke approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@clauswilke clauswilke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had this made it into a release already? If yes there should be a comment in the changelog. If no then it's all good.

@thomasp85
Copy link
Member Author

No this got merged in two weeks ago

@thomasp85 thomasp85 merged commit d26b19c into master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clauswilke clauswilke clauswilke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasp85 @clauswilke