Skip to content

Reflect more options to viridis_pal() #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2022

Conversation

yutannihilation
Copy link
Member

(Depends on r-lib/scales#306)

The dev version of viridisLite has 3 more options, so we need to update the document once it's released. This pull request might be a bit too early and I'll reflect the released version of the document. The main purpose of this is to notify here about the very fact there will be such additions.

https://sjmgarnier.github.io/viridisLite/reference/viridis.html

@thomasp85
Copy link
Member

can you make sure that the generated docs are up to date with viridis and then this is good to go

@yutannihilation
Copy link
Member Author

This is up to date with viridisLite package, but ahead of scales package. As our document refers to scales::viridis_pal(), not directly to viridisLite's functions, we need to wait for scales to be updated (i.e. r-lib/scales#306 gets merged) and released. Otherwise, the changes in this pull request will be just reverted when someone run devtools::document() with the released version of scales.

@thomasp85
Copy link
Member

I see... thanks

@z3tt
Copy link

z3tt commented Jan 21, 2022

Ah, looking through the issues first would have saved me lots of time while trying to trace down the documentation and why it is not up2date even though the options are mentioned in the viridisLite package.

Any chance this is going to be updated soon?

@yutannihilation
Copy link
Member Author

I'm afraid no chance, because the version of the scales package is not released on CRAN yet.

@hadley
Copy link
Member

hadley commented Mar 15, 2022

Are we still waiting for a scales release?

@yutannihilation
Copy link
Member Author

Yes.

@hadley
Copy link
Member

hadley commented Mar 16, 2022

Ok, I'll add that to my to do list.

@yutannihilation
Copy link
Member Author

Thanks for releasing the new version of scales! This should be ready to merge now.

@hadley hadley merged commit 488e5fb into tidyverse:main Apr 14, 2022
@yutannihilation yutannihilation deleted the doc/update-viridisLite branch April 14, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants