-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Reflect more options to viridis_pal() #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect more options to viridis_pal() #4412
Conversation
can you make sure that the generated docs are up to date with viridis and then this is good to go |
This is up to date with viridisLite package, but ahead of scales package. As our document refers to |
I see... thanks |
Ah, looking through the issues first would have saved me lots of time while trying to trace down the documentation and why it is not up2date even though the options are mentioned in the viridisLite package. Any chance this is going to be updated soon? |
I'm afraid no chance, because the version of the scales package is not released on CRAN yet. |
Are we still waiting for a scales release? |
Yes. |
Ok, I'll add that to my to do list. |
Thanks for releasing the new version of scales! This should be ready to merge now. |
(Depends on r-lib/scales#306)
The dev version of viridisLite has 3 more options, so we need to update the document once it's released. This pull request might be a bit too early and I'll reflect the released version of the document. The main purpose of this is to notify here about the very fact there will be such additions.
https://sjmgarnier.github.io/viridisLite/reference/viridis.html