Skip to content

Make sure guide_axis can modify labels in coord_flip #4441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

thomasp85
Copy link
Member

Fix #4289

This PR changes the order of calls in labels() to make sure that any guide_axis parts gets correctly applied

@thomasp85 thomasp85 added this to the ggplot2 3.3.4 milestone Apr 22, 2021
@thomasp85 thomasp85 requested a review from paleolimbot April 22, 2021 09:58
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant minimal solution to this! Looks great to me.

@thomasp85 thomasp85 merged commit eb91826 into master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dup_axis guide parameters don't apply to the right axis with coord_flip
2 participants