Skip to content

Update to newest CI #4656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 1, 2021
Merged

Update to newest CI #4656

merged 7 commits into from
Nov 1, 2021

Conversation

thomasp85
Copy link
Member

This updates our CI scripts to the latest version, hopefully removing the need for continuous keeping up with best practices.

@yutannihilation
Copy link
Member

Just a reminder, pak is not ready for our usages yet.

c.f. #4425 (comment)

@thomasp85
Copy link
Member Author

Ah - had forgotten about that...

@yutannihilation
Copy link
Member

mapproj also depends on maps, so we need a tweak for this as well.

At the time of introducing rlang::check_installed(), we didn't notice this problem of hard failure on tests... This is a bit annoying.

@thomasp85
Copy link
Member Author

yeah, OTOH we keep on top of missing reverse dependencies

@thomasp85
Copy link
Member Author

my god this is killing me

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

The "polygon edge not found" error on macOS runner should be occasional one so I bet we can ignore it (while I think it's great if we'll find the cause eventually).

@thomasp85 thomasp85 merged commit 08749f8 into main Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants