Use pak in R-CMD-check.yaml #4697
Conversation
|
This should be ready to merge now. |
.github/workflows/R-CMD-check.yaml
Outdated
| while read -r cmd | ||
| do | ||
| eval sudo $cmd | ||
| done < <(Rscript -e 'writeLines(remotes::system_requirements("ubuntu", "18.04"))') | ||
| - name: Install system dependencies on macOS | ||
| if: runner.os == 'macOS' | ||
| run: | | ||
| # XQuartz is needed by vdiffr |
There was a problem hiding this comment.
Is this still needed? I think XQuartz is provided by default now...
There was a problem hiding this comment.
Oh, really? Let's try removing this.
|
Hm, glue now requires R >= 3.4. Since we depend on glue very much, it might be a good time to consider dropping the support for R 3.3. |
|
Just drop it from the test suite - no need to add a hard dependency on 3.4 in the DESCRIPTION... |
|
I see. Considering the users with R 3.3 still can install ggplot2 if they install some older version of glue, just dropping it from the test suite is enough. |
|
Yes, that is my thinking |
|
Failures seems because of this problem. I'll rerun CI when the next version of sf gets released on CRAN. |
|
Closing in favor of #4747 |
It seems pak-based workflow is ready to use now. Let's see if this works...