Skip to content

Shorten the titles of visual tests to suppress warnings #4880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Shorten the titles of visual tests to suppress warnings #4880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ciding-limits-and-bins-showing-limits.svg → ...erstands-coinciding-limits-and-bins-3.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion ...ciding-limits-and-bins-showing-limits.svg → ...erstands-coinciding-limits-and-bins-3.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions tests/testthat/test-guides.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ test_that("binning scales understand the different combinations of limits, break
breaks = c(2000, 2002, 2004, 2006, 2008),
guide = 'bins')
)
expect_doppelganger("guide_bins understands coinciding limits and bins showing limits",
expect_doppelganger("guide_bins understands coinciding limits and bins 3",
p + scale_color_binned(limits = c(1999, 2008),
breaks = c(1999, 2000, 2002, 2004, 2006),
guide = 'bins', show.limits = TRUE)
Expand All @@ -631,7 +631,7 @@ test_that("binning scales understand the different combinations of limits, break
p + scale_color_binned(limits = c(1999, 2008),
breaks = c(2000, 2002, 2004, 2006, 2008))
)
expect_doppelganger("guide_colorsteps understands coinciding limits and bins showing limits",
expect_doppelganger("guide_colorsteps understands coinciding limits and bins 3",
p + scale_color_binned(limits = c(1999, 2008),
breaks = c(1999, 2000, 2002, 2004, 2006),
show.limits = TRUE)
Expand Down