Skip to content

Use linewidth more #4959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 24, 2022
Merged

Use linewidth more #4959

merged 2 commits into from
Aug 24, 2022

Conversation

yutannihilation
Copy link
Member

@yutannihilation yutannihilation commented Aug 23, 2022 •
edited
Loading

During reviewing #4956, I found several examples still use size where it should be linewidth. This pull request mainly fixes it as well as

  • Added sf:: prefix to the examples in annotation_map(). These don't fail just because they are in dontrun.
  • Fixed annotation_map(). It seems it was broken.
  • Add a note that pointrange() also understands size aesthetics in actual.

thomasp85
thomasp85 approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@yutannihilation yutannihilation merged commit de4c225 into tidyverse:main Aug 24, 2022
@yutannihilation yutannihilation deleted the doc/more-linewidth-everywhere branch August 24, 2022 09:47
@xiangpin xiangpin mentioned this pull request Feb 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutannihilation @thomasp85