-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Text size switch #5260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text size switch #5260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As garish as it is, arguments in ggplot2 are "." separated instead of "_" separated
Oops yes, fixed it |
I'm trying to figure out if mm and pt are too limiting since grid supports a multitude of units... maybe it is not so big a deal |
I can see some utility for absolute units, but I'd have no idea what to expect for |
yeah, I'm only thinking of adding the other absolute sizes, not the relative ones |
I've added centimetres, inches and picas in addition to the points and millimetres. Other absolute units are 'bigpts', 'dida', 'cicero' and 'scaledpts', but I've never seen anybody use these in the wild, so I didn't add them. Let me know if you'd like to add these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR aims to fix #3799.
Briefly, it adds a
size_unit
parameter togeom_text/label()
that allows one to use"pt"
to have the size interpreted as points.Example:
Created on 2023-04-05 with reprex v2.0.2