Skip to content

Use .tif as synonym to .tiff #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix part of #5323.

Just as .jpg is synonymous to .jpeg, so is .tif synonymous to .tiff.
This updates the device list to recognise .tif extensions in filenames.

Copy link
Member

@yutannihilation yutannihilation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Btw, is anyone looking at the visual test failures on R-devel? I checked at the release note of R-devel, but couldn't find anything that is apparently relevant.

@teunbrand
Copy link
Collaborator Author

Thanks for the review! The devel failures are due to changes in the density() function, see also #5296 (comment). I wish I knew an elegant solution to have the devel tests pass.

@teunbrand teunbrand merged commit 996cbd8 into tidyverse:main Jun 19, 2023
@teunbrand teunbrand deleted the tif_synonym branch June 19, 2023 16:11
@yutannihilation
Copy link
Member

Oh, I see. Thanks for the details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants