-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Version comparisons #5367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version comparisons #5367
Conversation
* de-duplicate contours * Add de-duplication test * Add NEWS bullet
* Apply alignment panel-wise instead of globally * Add NEWS bullets * Add unit test
* Update `coord_flip()` docs * Communicate `coord_flip()` as superseded
* Connect scales to aes documentation * Improvements to aes documentation * Crosslink aes documentation * Match aes to doc page * Prevent having to import `relist()` * Better crosslinks for position scales * Roxygenate * Add NEWS bullet * Fix clumsy merge * Fix clumsy merge part II
* Don't drop groups in stat_ydensity * Add `drop` argument as switch * Add test * Add NEWS bullet
* `geom_bar()` uses panelwise resolution * Add test * Add NEWS bullet
* Repair arrows in `!constant` branch * Add arrow repair tests * Add NEWS bullet * Move NEWS bullet
* mapped_discrete has resolution 1 * Add resolution test * Add NEWS bullet
I only now realised that the v3.4.2-rc branch already had folded in some of the main branch changes, and I'm unsure how to deal with that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I deleted your rc branch and created a new one from the 3.4.2 release tag (this is generally the way to go with these quick releases) |
Closing this in favour of #5376 |
* Reimplement #5367 * Override default density method
This PR aims to feed into #5366, anticipating this change.
It changes numeric version comparison to string version comparisons.
The PR is raised against a new RC branch originating from the v3.4.2-rc branch.