Skip to content

Version comparisons #5367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Conversation

teunbrand
Copy link
Collaborator

This PR aims to feed into #5366, anticipating this change.
It changes numeric version comparison to string version comparisons.
The PR is raised against a new RC branch originating from the v3.4.2-rc branch.

yutannihilation and others added 15 commits March 19, 2023 20:31
* de-duplicate contours

* Add de-duplication test

* Add NEWS bullet
* Apply alignment panel-wise instead of globally

* Add NEWS bullets

* Add unit test
* Update `coord_flip()` docs

* Communicate `coord_flip()` as superseded
* Connect scales to aes documentation

* Improvements to aes documentation

* Crosslink aes documentation

* Match aes to doc page

* Prevent having to import `relist()`

* Better crosslinks for position scales

* Roxygenate

* Add NEWS bullet

* Fix clumsy merge

* Fix clumsy merge part II
* Don't drop groups in stat_ydensity

* Add `drop` argument as switch

* Add test

* Add NEWS bullet
* `geom_bar()` uses panelwise resolution

* Add test

* Add NEWS bullet
* Repair arrows in `!constant` branch

* Add arrow repair tests

* Add NEWS bullet

* Move NEWS bullet
* mapped_discrete has resolution 1

* Add resolution test

* Add NEWS bullet
@teunbrand teunbrand requested a review from thomasp85 July 26, 2023 21:07
@teunbrand
Copy link
Collaborator Author

I only now realised that the v3.4.2-rc branch already had folded in some of the main branch changes, and I'm unsure how to deal with that.

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasp85 thomasp85 deleted the branch tidyverse:v3.4.3-rc August 1, 2023 08:09
@thomasp85 thomasp85 closed this Aug 1, 2023
@thomasp85 thomasp85 reopened this Aug 1, 2023
@thomasp85
Copy link
Member

I deleted your rc branch and created a new one from the 3.4.2 release tag (this is generally the way to go with these quick releases)

teunbrand added a commit to teunbrand/ggplot2 that referenced this pull request Aug 1, 2023
@teunbrand teunbrand mentioned this pull request Aug 1, 2023
@teunbrand
Copy link
Collaborator Author

Closing this in favour of #5376

@teunbrand teunbrand closed this Aug 1, 2023
teunbrand added a commit that referenced this pull request Aug 1, 2023
* Reimplement #5367

* Override default density method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants