Fix guide_axis_theta()
expression label bug
#5577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I apologise for not filing an issue first, but I ran into the following bug.
On the main branch, expressions aren't rendered properly with
guide_axis_theta()
. You can see in the example below, the subscript and superscript aren't drawn appropriately.Created on 2023-12-12 with reprex v2.0.2
The same reprex with this PR draws them appropriately:
The implemented fix is easy: instead of taking the native labels as extracted from the scale, we use the
validate_labels()
function that handles expressions correctly.