Skip to content

adhere to strip placement even if the axis is empty #5630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2024
Merged

adhere to strip placement even if the axis is empty #5630

merged 1 commit into from
Jan 5, 2024

Conversation

thomasp85
Copy link
Member

As discussed internally, the order of strips and axes does not follow the strip.placement setting for empty axes. This is fixed with this PR

@thomasp85 thomasp85 added this to the ggplot2 3.5.0 milestone Jan 4, 2024
@thomasp85 thomasp85 requested a review from teunbrand January 4, 2024 14:09
teunbrand
teunbrand approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fix looks good, but it might be worth streamlining these pieces of code later down the road somewhere.

@thomasp85 thomasp85 merged commit 9c15f81 into rc/3.5.0 Jan 5, 2024
thomasp85 added a commit that referenced this pull request Feb 23, 2024
@thomasp85
adhere to strip placement even if the axis is empty (#5630)
e2949d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasp85 @teunbrand