Skip to content

Restore legend.byrow #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 26, 2024
Merged

Restore legend.byrow #5662

merged 4 commits into from
Jan 26, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR to the RC aims to fix #5661.

Briefly the legend.byrow setting wasn't working because the code assumed it was in params whereas we swapped it to elements later.

This made me realise that Guide$arrange_layout() needed access to the elements (instead of sneakily passing it through size ), so this PR also adds elements as an argument.

I was also surprised that there was no test for the legend.byrow setting, so I added one.

@teunbrand teunbrand changed the base branch from main to rc/3.5.0 January 25, 2024 08:37
@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Jan 25, 2024
@teunbrand teunbrand changed the base branch from rc/3.5.0 to main January 25, 2024 09:13
@teunbrand teunbrand changed the base branch from main to rc/3.5.0 January 25, 2024 09:13
@teunbrand teunbrand changed the base branch from rc/3.5.0 to main January 25, 2024 09:14
@teunbrand teunbrand changed the base branch from main to rc/3.5.0 January 25, 2024 09:15
thomasp85
thomasp85 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 617c336 into tidyverse:rc/3.5.0 Jan 26, 2024
@teunbrand teunbrand deleted the restore_legend_byrow branch January 26, 2024 09:36
@teunbrand teunbrand mentioned this pull request Jan 30, 2024
Closed
thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
@teunbrand @thomasp85
Restore legend.byrow (#5662)
599953f 
* add `elements` to `arrange_layout`

* Fix `byrow`

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.

legend.byrow = TRUE doesn't seem to be working
2 participants
@teunbrand @thomasp85