Skip to content

Radial inner radius #5679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2024
Merged

Radial inner radius #5679

merged 2 commits into from
Feb 12, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to implement an internally discussed suggestion.

It renames the donut argument of coord_radial() to inner.radius.

@teunbrand teunbrand changed the base branch from main to rc/3.5.0 February 6, 2024 08:15
@teunbrand teunbrand added this to the ggplot2 3.5.0 milestone Feb 6, 2024
@teunbrand teunbrand requested a review from thomasp85 February 6, 2024 09:29
thomasp85
thomasp85 approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 7378156 into tidyverse:rc/3.5.0 Feb 12, 2024
@teunbrand teunbrand deleted the radial_inner_radius branch February 12, 2024 12:03
thomasp85 pushed a commit that referenced this pull request Feb 23, 2024
@teunbrand @thomasp85
Radial inner radius (#5679)
465ef21 
* rename `donut` -> `inner.radius`

* regenerate docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85