Skip to content

Mention size.unit option in vignette #5798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

Mention size.unit option in vignette #5798

merged 1 commit into from
Apr 2, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5792.

Since the diff is hard to read, I've added this line:

In geom_text() and geom_label(), you can set size.unit = "pt" to use points instead of millimeters. In addition,

@teunbrand teunbrand changed the title Mention size.unit option Mention size.unit option in vignette Mar 25, 2024
@teunbrand teunbrand added this to the ggplot2 3.5.1 milestone Mar 25, 2024
thomasp85
thomasp85 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 75e3112 into tidyverse:main Apr 2, 2024
@teunbrand teunbrand deleted the vignette_text_size branch April 2, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 3.5.1
Development

Successfully merging this pull request may close these issues.

Update vignette for geom_text(size.unit) setting
2 participants
@teunbrand @thomasp85