Skip to content

Pass missing arguments in guide_coloursteps() #5931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5930.

Briefly, I forgot to pass position and available_aes to new_guide(), which this PR fixes.

Reprex from issue:

devtools::load_all("~/packages/ggplot2")
#> ℹ Loading ggplot2

ggplot(mpg, aes(displ, hwy, colour = cty)) +
  geom_point() +
  guides(color=guide_colorsteps(position = "bottom"))

Created on 2024-06-04 with reprex v2.1.0

Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once a NEWS bullet is added

@teunbrand teunbrand merged commit b11d574 into tidyverse:main Jul 11, 2024
11 checks passed
@teunbrand teunbrand deleted the coloursteps_position branch July 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guide_colorsteps() can't set the position
2 participants