Skip to content

Fix regression from #6027 #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix regression from #6027 #6098

merged 2 commits into from
Sep 23, 2024

Conversation

teunbrand
Copy link
Collaborator

This PR fixes a regression introduced by #6027, that is detectable as:

ggplot2/revdep/problems.md

Lines 18570 to 18572 in d31c051

7. └─self$coord$setup_params(data)
8. └─ggplot2 (local) setup_params(..., self = self)
9. └─ggplot2:::parse_coord_expand(expand = self$expand %||% TRUE)

The regression occurs when expand = 0 or expand = 1 is set in the coord, and this PR makes this valid input again.

thomasp85
thomasp85 approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maybe worth a unit test

@teunbrand teunbrand merged commit 7f6d5bf into tidyverse:main Sep 23, 2024
13 checks passed
@teunbrand teunbrand deleted the expand_accepts_01 branch September 23, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teunbrand @thomasp85