Skip to content

Encourage specifying breaks when giving labels as a vector #6237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Encourage specifying breaks when giving labels as a vector #6237

merged 1 commit into from
Jan 28, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #5208.

Briefly, it implements the advice in #5208 (comment) in the documentation:

I have long operated under the rule of thumb that one should never specify labels without specifying breaks. We could just formalize that rule.

thomasp85
thomasp85 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teunbrand teunbrand merged commit 1b9ee73 into tidyverse:main Jan 28, 2025
13 checks passed
@teunbrand teunbrand deleted the recommend_breaks_if_label branch January 28, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scale_shape_manual mislabels if label argument is given and names in values are not alphabetical
2 participants
@teunbrand @thomasp85