Forward compatibility: is_*() functions
#6388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
commented
Apr 1, 2025
Comment on lines
+151
to
+164
| is_element <- function(x, type = "any") { | ||
| switch( | ||
| type %||% "any", | ||
| any = inherits(x, "element"), | ||
| rect = inherits(x, "element_rect"), | ||
| line = inherits(x, "element_line"), | ||
| text = inherits(x, "element_text"), | ||
| blank = inherits(x, "element_blank"), | ||
| # TODO: ideally we accept more elements from extensions. We need to | ||
| # consider how this will work with S7 classes, where ggplot2 doesn't know | ||
| # about the extension's class objects. | ||
| FALSE | ||
| ) | ||
| } |
There was a problem hiding this comment.
Thomas, I'd like to draw your eye to this bit with regard to the comment here
There was a problem hiding this comment.
I don't think we need to support anything but our own classes here tbh
thomasp85
approved these changes
Apr 3, 2025
Comment on lines
+151
to
+164
| is_element <- function(x, type = "any") { | ||
| switch( | ||
| type %||% "any", | ||
| any = inherits(x, "element"), | ||
| rect = inherits(x, "element_rect"), | ||
| line = inherits(x, "element_line"), | ||
| text = inherits(x, "element_text"), | ||
| blank = inherits(x, "element_blank"), | ||
| # TODO: ideally we accept more elements from extensions. We need to | ||
| # consider how this will work with S7 classes, where ggplot2 doesn't know | ||
| # about the extension's class objects. | ||
| FALSE | ||
| ) | ||
| } |
There was a problem hiding this comment.
I don't think we need to support anything but our own classes here tbh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve forwards compatibility.
Briefly, it re-implements parts of #6022 specifically the test functions. We deviate from that PR through deprecating dot.case functions and introducing snake_case function names are used instead.
Notably,
is_element(x, type = ....)allows one to test for specific subtypes of elements as well.