Skip to content

Watch potential partial matches in Geom/Stat parameters #6428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 19, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6408.

The important bit is that it includes a snapshot test for all potential partial matches in Geom/Stat parameter names.
Also it fixes potential issues that were found using the test.

@Yunuuuu
Copy link
Contributor

Yunuuuu commented Apr 17, 2025

In PR #6410, the commit c074273 also helps address other partial arguments matching. Would it possible to include this commit as part of the PR?

@teunbrand
Copy link
Collaborator Author

I've cherry-picked the commit from #6410

@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 6, 2025
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merge branch 'main' into watch_partial_matches

# Conflicts:
#	R/stat-manual.R
#	R/stat-ydensity.R
@teunbrand teunbrand merged commit 6cad87d into tidyverse:main May 19, 2025
13 checks passed
@teunbrand teunbrand deleted the watch_partial_matches branch May 19, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parameters due to partial matching
3 participants