Skip to content

Upkeep spring 2025 #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 20, 2025
Merged

Upkeep spring 2025 #6440

merged 12 commits into from
May 20, 2025

Conversation

teunbrand
Copy link
Collaborator

This PR aims to fix #6439.

Few notes:

  • Didn't commit to using air yet, as discussed
  • \(x) syntax only when functions fit in one line in examples, not internal code
  • Chunk headers were already in yaml style
  • Already using expect_snapshot(error = TRUE)
  • Only bumped MIT licence year, as we want to retain the 'core developers' as authors
  • I assumed some GHA rules are custom, so I just bumped versions
  • Already using alt text
  • Not sure wether the Re-publish released site applies here

@teunbrand teunbrand added this to the ggplot2 4.0.0 milestone May 6, 2025
thomasp85
thomasp85 approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@thomasp85 thomasp85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the single comment LGTM

teunbrand added 3 commits May 20, 2025 08:57
@teunbrand
resolve merge conflict
f58b6ec 
Merge branch 'main' into upkeep-2025-04

# Conflicts:
#	R/geom-histogram.R
@teunbrand
exempt cut3() from short function form
b982453
@teunbrand
redocument
60f6870
@teunbrand teunbrand merged commit 3914e13 into main May 20, 2025
13 checks passed
@teunbrand teunbrand deleted the upkeep-2025-04 branch May 20, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasp85 thomasp85 thomasp85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ggplot2 4.0.0
Development

Successfully merging this pull request may close these issues.

Upkeep for ggplot2 (2025)
2 participants
@teunbrand @thomasp85