Skip to content

Extra information for the 'position' parameter. #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

williamlai2
Copy link
Contributor

Extra information on the possible values for 'position'.

Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are a few issues with the proposed changes.

  • This seems to be based on the 3.5.2 version, can you merge in the main branch?
  • The documentation needs to be regenerated with devtools::document()
  • See comment below

Comment on lines 20 to +21
#' placed relative to the plot panels.
One of "top", "right", "bottom", "left", or "inside".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs a roxygen comment #' in front.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'll make the changes. I might close this one though and put in a new pull request though. I ran devtools::document() and there are are a lot of minor changes to the documentation for other functions, though I'll just add the relevant ones.

@williamlai2 williamlai2 changed the title Extra information on the 'position' parameter. Extra information for the 'position' parameter. May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants