Ensure ggproto methods start with {
#6460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into yjunechoe-curly-braces-ggproto-methods # Conflicts: # R/coord-.R # R/coord-cartesian-.R # R/coord-transform.R # R/facet-.R # R/geom-.R # R/stat-unique.R
|
Sorry for assuming a little bit of control over the PR, but some gnarly merge conflicts had emerged that were my fault. I also tweaked the test a little bit so that now it'll report which ggprotos and which method is failing. |
teunbrand
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #6459, this PR changes instances of
function() ...intofunction() { ... }for ggproto methods.There was one not-so-trivial case of
ScaleDiscrete$transform:ggplot2/R/scale-.R
Lines 981 to 983 in 86b32ce
Because
base::identity()is a one-liner without{, this fails the test:In this PR,
ScaleDiscrete$transformis now the spelled-out version: