Document all themes together #933
Conversation
Add a slightly more detailed description of the themes and a few words about their intent. Add examples to ease comparison
|
I'm not sure about the documentation of the "intent" of each theme. Please feel free to ask for any change. |
|
Also, shouldn't |
|
Finally, I really find the facet strips in |
| theme_light <- function(base_size = 12, base_family = "") { | ||
| # Starts with theme_grey and then modify some parts | ||
| theme_grey(base_size = base_size, base_family = base_family) %+replace% | ||
| theme( | ||
| axis.ticks = element_line(colour = "grey50", size = 0.25), | ||
| axis.ticks = element_line(colour = "grey70", size = 0.25), |
There was a problem hiding this comment.
Yes they are. Documenting the functions together made it easier to compare them and it this theme needed to be a little lighter to better differentiate it from others.
|
This looks like it would be a perfect use case for the new |
|
I'm happy for tweaks to |
| #' @aliases theme_gray theme_grey | ||
| #' @export theme_gray theme_grey | ||
| #' @family themes | ||
| #' @rdname ggtheme |
There was a problem hiding this comment.
For symmetry, I think it would be better to do
#' @name ggtheme
NULL
#' @export
#' @rdname ggtheme
theme_bw <- ...
There was a problem hiding this comment.
Except that doing it this way make roxygen think ggtheme is a data type and using @describeIn complains: Don't know how to describe function in data.
Any advice?
There was a problem hiding this comment.
Good point. Not sure how to make this work my way - stick with your way.
Make all themes symmetrically reference the general ggtheme documentation Document theme_grey and theme_gray
|
The documentation is now done. |
|
Thanks! |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Add a slightly more detailed description of the themes and a few words
about their intent. Add examples to ease comparison.