Skip to content

Update save.r #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 26, 2014
Merged

Update save.r #936

merged 2 commits into from
Mar 26, 2014

Conversation

arilamstein
Copy link
Contributor

The parameter is called "filename", but the examples use "file".

The parameter is called "filename", but the examples use "file".
@hadley
Copy link
Member

hadley commented Mar 25, 2014

Since filename is the first argument, I think it would be better style to drop the name altogether.

…efinition. Do not use variable names in example function calls when variables are in correct order.
@arilamstein
Copy link
Contributor Author

I just made that change, and also made the parameter order in the examples the same as the function definition.

hadley added a commit that referenced this pull request Mar 26, 2014
@hadley hadley merged commit 4b08fea into tidyverse:master Mar 26, 2014
@hadley
Copy link
Member

hadley commented Mar 26, 2014

Thanks!

@arilamstein
Copy link
Contributor Author

Neat! I've been using ggplot2 for over a year and really enjoy it. It never occured to me that I might one day make a contribution to it.

@lock
Copy link

lock bot commented Jan 19, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants