Facet titles #974
Merged
Facet titles #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea. Can you please re-document and merge/rebase so I can do a review on cleaner code? (A bit of commit squashing wouldn't hurt either) |
lionel-
force-pushed
the
facet-titles
branch
2 times, most recently
from
efaa6b5 to
c6583c1
Compare
|
Here you go. |
| @@ -174,6 +174,10 @@ print.theme <- function(x, ...) str(x) | |||
| #' (\code{element_text}; inherits from \code{strip.text}) \cr | |||
| #' strip.text.y \tab facet labels along vertical direction | |||
| #' (\code{element_text}; inherits from \code{strip.text}) \cr | |||
| #' strip.switch.pad.grid \tab space between strips and axes when strips are switched | |||
| #' (\code{unit} \cr | |||
|
Overall, looks good. A few minor nit-picks inline. |
|
voilà |
| as axes subtitles. Can be set to "x", "y" or "both" (the latter only | ||
| for grids) to control which label strips are switched. (@lionel-) | ||
|
|
||
| * `Geom` is now exported, making it easier to create new geoms in other |
There was a problem hiding this comment.
This got messed up, but I can fix it.
|
Thanks! People are really going to like this feature |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a
switch_stripsargument tofacet_wrapandfacet_grid, which can be set tox,yorboth(the latter only for grids). This allows to display the facet strips near the axes. They then act as axes subtitles. The padding between the switched strips and their corresponding axes can be adjusted through a new theme setting.Displaying the facet titles near the axes especially makes sense when the facet title directly characterize a change in the axis (for example, a transformation, a different measure, etc). This should be typically used in conjunction with a theme without boxes around the strips. I go over this in the updated documentation.
A grid facetting with strips switched to both axes:
A wrap facetting with free scales and strips switched to the x axis:
